Skip to content

Conversation

victoreronmosele
Copy link
Contributor

@victoreronmosele victoreronmosele commented Aug 13, 2025

This PR fixes the broken links in the README.md.

Test exemption reason: PR only affects .md files..

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Aug 13, 2025
@victoreronmosele victoreronmosele marked this pull request as ready for review August 13, 2025 05:25
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several links in README.md that were pointing to old paths and also prepares a new package release by updating pubspec.yaml and CHANGELOG.md. The changes are correct and improve the documentation's accuracy.

For consistency, you might consider updating other links in README.md that still use the old /formats/ path and are being redirected. For example, the links for parseDataFile and parseLibraryFile could also be updated.

@victoreronmosele
Copy link
Contributor Author

victoreronmosele commented Aug 13, 2025

parseDataFile and parseLibraryFile do not need to be updated as they are hidden from the rfw library but exposed through the formats library. So the /formats/ path is correct for them.

See

export 'src/dart/text.dart' hide parseDataFile, parseLibraryFile;
and
export 'src/dart/text.dart';

@stuartmorgan-g stuartmorgan-g self-requested a review August 19, 2025 18:19
@victoreronmosele victoreronmosele force-pushed the update-broken-links-in-readme branch from 21ece5a to 32945b2 Compare August 28, 2025 07:05
@victoreronmosele victoreronmosele force-pushed the update-broken-links-in-readme branch from 32945b2 to bb462ea Compare August 28, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant