[image_picker] Add the ability to pick multiple videos - platform implementations #9818
+1,004
−361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va/io/flutter/plugins/imagepicker/ImagePickerDelegate.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
stuartmorgan-g
requested review from
vashworth,
LouiseHsu,
gmackall and
ditman
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the ability to pick multiple videos by introducing the getMultiVideoWithOptions method. The feature is implemented across Android, iOS, web, Linux, and macOS platforms. The changes include necessary native code modifications, Dart API implementations, updates to example applications to demonstrate the new functionality, and additions to the test suites to ensure correctness. A significant refactoring was also done in the iOS implementation to unify the picker launching logic. The overall implementation is solid, but I found a minor issue in one of the new tests.
packages/image_picker/image_picker_ios/test/image_picker_ios_test.dart
Outdated
Show resolved
Hide resolved
tarrinneal
approved these changes
Aug 16, 2025
stuartmorgan-g
added
the
autosubmit
CaoGiaHieu-dev
added a commit
to CaoGiaHieu-dev/packages
that referenced
this pull request
Aug 18, 2025
* main: (24 commits) Roll Flutter from 0a2906b81d5e to b3fb4c786d80 (5 revisions) (flutter#9840) Update repo for 3.35 stable release (flutter#9816) Roll Flutter from 52af7a504025 to 0a2906b81d5e (16 revisions) (flutter#9836) [image_picker] Updates min SDK to 3.29 (flutter#9830) [image_picker] Add the ability to pick multiple videos (flutter#9775) [image_picker] Add the ability to pick multiple videos - platform implementations (flutter#9818) [various] Updates min SDK for third_party/packages to 3.29 (flutter#9819) [vector_graphics] Updates min SDK to 3.29 (flutter#9820) [google_maps_flutter] Updates min SDK to 3.29 (flutter#9821) [video_player] Updates min SDK to 3.29 (flutter#9826) [shared_preferences] Updates min SDK to 3.29 (flutter#9829) [image_picker_ios] Add photo to simulator Photos library during test (flutter#9759) [interactive_media_ads] Updates `README` with information about enabling desugaring on Android (flutter#9790) [in_app_purchase] Updates min SDK to 3.29 (flutter#9825) Roll Flutter from f4334d27934b to 52af7a504025 (29 revisions) (flutter#9832) [go_router] Update generated output format (flutter#9817) [video_player] Move Android buffer updates to Dart (flutter#9771) [webview_flutter] Add support for payment requests on Android (flutter#9679) [vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix (flutter#9813) [url_launcher_ios] Fix test button text to work on iOS 26 (flutter#9766) ... # Conflicts: # packages/go_router_builder/CHANGELOG.md # packages/go_router_builder/example/lib/all_types.g.dart # packages/go_router_builder/example/lib/main.g.dart # packages/go_router_builder/example/lib/shell_route_with_keys_example.g.dart # packages/go_router_builder/example/lib/shell_route_with_observers_example.g.dart
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2025
…atform implementations (flutter/packages#9818)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2025
…atform implementations (flutter/packages#9818)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2025
…atform implementations (flutter/packages#9818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementation portion of #9775
This adds support for the new
getMultiVideoWithOptionsmethod to all implementation packages.Part of flutter/flutter#102283
Fixes flutter/flutter#146400
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3