-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[video_player] Adds audio track metadata fetching and audio track selection feature #9925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nateshmbhat
wants to merge
39
commits into
flutter:main
Choose a base branch
from
nateshmbhat:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,769
−5
Open
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
c8b0071
feat(video_player): add audio track selection support for iOS and And…
nateshmbhat 4e4dc8c
feat(android): implement audio track selection in video player
nateshmbhat 25de26c
feat(video_player): Format Entire Codebase
nateshmbhat 31f9030
feat(video_player): add audio track selection and retrieval functiona…
nateshmbhat 8f711b5
test(video_player): add tests for audio track selection and management
nateshmbhat e0f6d65
fix(video): address PR review comments
nateshmbhat fc30013
Merge branch 'main' into develop
nateshmbhat 8a68e76
fix(video_player): add delay after audio track selection to handle Ex…
nateshmbhat 894f516
test(video_player): update audio tracks test to use ImmutableList and…
nateshmbhat 644e08e
Merge branch 'develop' of github.com:nateshmbhat/flutter_packages int…
nateshmbhat fdde6f8
refactor(tests): move audio track tests from AudioTracksTests.m to Vi…
nateshmbhat 4291609
fix(ios,android): fixed test failure cases (linting and warnings)
nateshmbhat 8dfd8e3
style(audio_tracks): improve code style and add type safety in audio …
nateshmbhat a892a5e
chore(android): bump compileSdk from 34 to 35 for video player plugin
nateshmbhat 1537778
Merge branch 'main' into develop
nateshmbhat c222584
Merge branch 'main' into develop
nateshmbhat f087fe1
refactor(video): improve video player controller handling and code fo…
nateshmbhat 2e4c9ac
Merge branch 'main' into develop
nateshmbhat 652dd48
refactor(video): improve video player state management and UI components
nateshmbhat 80bda36
refactor(ios): improve audio track format parsing with better mock ob…
nateshmbhat 1495a95
refactor(ios): optimize audio track metadata lookup using AVMetadataI…
nateshmbhat ad558a7
refactor(video): move ExoPlayer delay from demo to controller impleme…
nateshmbhat 6c7fd2b
Merge pull request #1 from nateshmbhat/19-sept-pr-review-changes
nateshmbhat 85a8f54
Merge branch 'main' into develop
nateshmbhat ac54143
feat(video_player): add platform check for audio track selection support
nateshmbhat 1775e23
Merge pull request #2 from nateshmbhat/19-sept-pr-review-changes
nateshmbhat 6dafd5f
Merge branch 'develop' of github.com:nateshmbhat/flutter_packages int…
nateshmbhat 9440d1b
style(dart): format code and improve readability with proper line breaks
nateshmbhat a65ebaf
chore(deps): format dependency overrides and add video_player_web path
nateshmbhat 7798aaa
chore(deps): add video_player_web dependency and update package overr…
nateshmbhat e912f6d
fix(video_player): add web platform check for audio track selection d…
nateshmbhat 3ae0519
Merge branch 'main' into develop
nateshmbhat 99cdbd6
fix(video_player): remove fallback labels for audio tracks in Android…
nateshmbhat e7895ef
Merge branch 'main' into develop
nateshmbhat 4e9b50b
Merge branch 'main' into develop
nateshmbhat 5c32bf3
chore(license): update copyright headers in video player files
nateshmbhat 5101efc
chore(license): remove trailing period from copyright headers
nateshmbhat f0bdabd
Merge branch 'main' into develop
nateshmbhat e7b3da0
chore(release): bump video_player packages to next version with audio…
nateshmbhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.