Skip to content

Add deprecation breaking change for app bar color #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add deprecation breaking change for app bar color #12156

wants to merge 7 commits into from

Conversation

rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Jun 26, 2025 •
edited
Loading

This PR add breaking changes migration guide for app bar theme color

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@rkishan516 rkishan516 mentioned this pull request Jun 26, 2025
Merged
9 tasks
sfshaza2
sfshaza2 reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, @rkishan516. But, overall, lgtm. Before I can approve, can you also add this breaking change to the index page?

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Jun 26, 2025
@rkishan516
Copy link
Contributor Author

@sfshaza2 I have added it to breaking changes to index in not yet released section.

@rkishan516 rkishan516 marked this pull request as ready for review July 17, 2025 09:07
@rkishan516 rkishan516 requested review from antfitch, parlough and a team as code owners July 17, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 left review comments

@antfitch antfitch Awaiting requested review from antfitch antfitch is a code owner

@parlough parlough Awaiting requested review from parlough parlough is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkishan516 @sfshaza2