-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add RepeatingAnimationBuilder to the widget catalog #12870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @loic-sharma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the new RepeatingAnimationBuilder widget to the widget catalog. The change is straightforward and correctly places the new widget alphabetically. My only suggestion is to update the documentation link to point to the main-api.flutter.dev domain, consistent with other widgets that are not yet in a stable release. This will ensure the link is not broken for users browsing the catalog.
| categories: | ||
| - 'Animation and motion' | ||
| subcategories: [] | ||
| link: https://api.flutter.dev/flutter/widgets/RepeatingAnimationBuilder-class.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions that this widget is not yet in a stable release and provides a link to the documentation on main-api.flutter.dev. To maintain consistency with other pre-release widgets in this catalog (like CarouselView), it would be better to use the main-api link here. The link can be updated to point to api.flutter.dev once the widget is part of a stable release.
link: https://main-api.flutter.dev/flutter/widgets/RepeatingAnimationBuilder-class.html|
Visit the preview URL for this PR (updated for commit 58f4868): https://flutter-docs-prod--pr12870-repeating-animation-builder-evmvoahe.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but don't land until next stable release.
This adds
RepeatingAnimationBuilderto the widget catalog. Preview:See also:
RepeatedTweenAnimationBuilderAPI flutter#174011RepeatingAnimationBuilderAPI flutter#174014Presubmit checklist
of 80 characters or fewer.