Skip to content

Conversation

@sfshaza2
Copy link
Contributor

@sfshaza2 sfshaza2 commented Jan 9, 2026

Fixes #12898. Adds a troubleshooting section to upgrade.md for the 'Filename too long' error on Windows.

@sfshaza2 sfshaza2 requested a review from a team as a code owner January 9, 2026 17:23
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 9, 2026

Summary of Changes

Hello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation by addressing a common Windows-specific issue that prevents users from upgrading Flutter due to file path length limitations. It provides clear, actionable steps to resolve this problem. Additionally, it refines the breaking changes documentation by ensuring that specific changes are accurately listed under their corresponding Flutter release versions, improving the clarity and accuracy of release notes.

Highlights

  • Windows Troubleshooting: A new troubleshooting section has been added to upgrade.md specifically for Windows users encountering the 'Filename too long' error during flutter upgrade.
  • Long Path Resolution: The solution provided for the 'Filename too long' error involves enabling long paths support in Git using the command git config --system core.longpaths true.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful troubleshooting guide for the 'Filename too long' error on Windows. The added documentation is clear and provides a valid solution. I've suggested a small improvement to make the instructions for the git config command even clearer for users.

Additionally, I noticed some changes in src/content/release/breaking-changes/index.md that seem unrelated to the main goal of this PR. These changes incorrectly move two breaking changes into 'released' sections when their documentation indicates they are not yet stable. I've left a comment recommending these changes be reverted to maintain accuracy.

I am having trouble creating individual review comments. Click here to see my feedback.

src/content/release/breaking-changes/index.md (40-41)

high

These breaking changes appear to be moved to 'released' sections prematurely. According to their respective documentation files (asset-manifest-dot-json.md and flutter-root-version-file.md), neither of these changes has been released to a stable version yet. They should remain under the 'Not yet released to stable' section. Please revert the changes in this file.

src/content/install/upgrade.md (185-191)

medium

The current instructions could be clearer. It's better to inform the user about the need for administrator privileges upfront, rather than as a conditional step after a potential failure.

To resolve this issue, enable long paths support in Git by running the following command in a terminal as an administrator:

```console
$ git config --system core.longpaths true

@sfshaza2 sfshaza2 force-pushed the fix-12898-windows-path branch from d055dc3 to f72bce5 Compare January 9, 2026 17:26
@sfshaza2
Copy link
Contributor Author

sfshaza2 commented Jan 9, 2026

Note to bot: this PR shouldn't look at the breaking change page at all.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 9, 2026

Visit the preview URL for this PR (updated for commit 409485d):

https://flutter-docs-prod--pr12905-fix-12898-windows-path-xikssvd9.web.app

@sfshaza2 sfshaza2 requested a review from camsim99 January 9, 2026 17:32
@camsim99
Copy link
Contributor

camsim99 commented Jan 9, 2026

@loic-sharma can you take a look at this?

Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this guide!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfshaza2 sfshaza2 merged commit 5330284 into main Jan 9, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the fix-12898-windows-path branch January 9, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading error

5 participants