-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: Add troubleshooting for Windows filename too long error (#12898) #12905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation by addressing a common Windows-specific issue that prevents users from upgrading Flutter due to file path length limitations. It provides clear, actionable steps to resolve this problem. Additionally, it refines the breaking changes documentation by ensuring that specific changes are accurately listed under their corresponding Flutter release versions, improving the clarity and accuracy of release notes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a helpful troubleshooting guide for the 'Filename too long' error on Windows. The added documentation is clear and provides a valid solution. I've suggested a small improvement to make the instructions for the git config command even clearer for users.
Additionally, I noticed some changes in src/content/release/breaking-changes/index.md that seem unrelated to the main goal of this PR. These changes incorrectly move two breaking changes into 'released' sections when their documentation indicates they are not yet stable. I've left a comment recommending these changes be reverted to maintain accuracy.
I am having trouble creating individual review comments. Click here to see my feedback.
src/content/release/breaking-changes/index.md (40-41)
These breaking changes appear to be moved to 'released' sections prematurely. According to their respective documentation files (asset-manifest-dot-json.md and flutter-root-version-file.md), neither of these changes has been released to a stable version yet. They should remain under the 'Not yet released to stable' section. Please revert the changes in this file.
src/content/install/upgrade.md (185-191)
The current instructions could be clearer. It's better to inform the user about the need for administrator privileges upfront, rather than as a conditional step after a potential failure.
To resolve this issue, enable long paths support in Git by running the following command in a terminal as an administrator:
```console
$ git config --system core.longpaths true
d055dc3 to
f72bce5
Compare
|
Note to bot: this PR shouldn't look at the breaking change page at all. |
|
Visit the preview URL for this PR (updated for commit 409485d): https://flutter-docs-prod--pr12905-fix-12898-windows-path-xikssvd9.web.app |
|
@loic-sharma can you take a look at this? |
loic-sharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this guide!
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #12898. Adds a troubleshooting section to upgrade.md for the 'Filename too long' error on Windows.