-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[FWE] Update site structure and sidenav #12935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ericwindmill, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive overhaul of the site's navigation and content structure, particularly within the 'Get Started' and 'Learn Flutter' sections. The primary goal is to enhance user experience by simplifying the sidenav, consolidating related content, and ensuring smooth transitions through redirects for relocated pages. This change aims to provide a clearer and more intuitive journey for new and existing users navigating the Flutter documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively restructures the 'Get Started' section of the website, simplifying the side navigation and implementing necessary redirects. The changes are consistent with the goal of replacing the 'Fundamentals' section and moving content to new /install and /learn paths. The overall organization is much cleaner as a result.
|
Visit the preview URL for this PR (updated for commit c69f3bd): https://flutter-docs-prod--pr12935-ew-fwe-nav-hj37p6xp.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, once the build error is addressed (there are some internal broken links).
Description of what this PR is changing or adding, and why:
This PR "lands FWE" by replacing Fundamentals in the sidenav with FWE, and generally cleaning up the Get Started sidenav section. This PR seems much larger than it is because some files moved location and other files were deleted. The easiest way to see the real changes is looking at the
sidenav.ymlfile./get-startedfolder altogether (movesflutter-forto its own locationIssues fixed by this PR (if any):
#12068
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.