Fix top nav

[ericwindmill]

I forgot to remove this conditional rendering of the top nav when FWE landed.

Presubmit checklist

• If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
• If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
• This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
• This PR uses semantic line breaks
  of 80 characters or fewer.

[gemini-code-assist]

Summary of Changes

Hello @ericwindmill, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the top navigation was not consistently displayed due to a conditional rendering that was mistakenly left in place after a feature flag was removed. The primary change is the removal of this conditional rendering, ensuring that the top navigation is always visible. Additionally, the CSS styles hash has been updated, possibly reflecting changes in the site's styling.

Highlights

• Top Nav Conditional Rendering Removal: The primary change involves removing the conditional rendering of the top navigation bar. Previously, the navigation items were only displayed when the activeEntry was set to ActiveNavEntry.learn. This change ensures that the top navigation is always visible, regardless of the active entry.
• CSS Styles Hash Update: The generated styles hash in site/lib/src/style_hash.dart has been updated to an empty string. This may be related to changes in the CSS styling of the site, or a step in a build process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the conditional rendering of the top navigation bar, making it always visible as intended. The change in site/lib/src/components/layout/header.dart is straightforward and correct. However, there is also a change in site/lib/src/style_hash.dart which sets the CSS hash to an empty string. This is likely an unintentional side-effect of a local build and could cause caching issues in production. I've added a comment to recommend reverting this change.

[flutter-website-bot]

Visit the preview URL for this PR (updated for commit b283690):

https://flutter-docs-prod--pr12940-ew-hide-top-nav-boslhy3q.web.app

[sfshaza2]

lgtm