Docs: Update AASA guidelines to use components #12978
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the documentation for configuring Apple App Site Association (AASA) files, specifically for setting up universal links. It updates the recommended approach to utilize the 'components' field for defining URL patterns, which is suitable for iOS 13 and later, while also providing clear guidance on how to maintain support for older iOS versions by retaining the 'paths' field. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the universal links setup guide for iOS to use the modern components field in the apple-app-site-association file, replacing the legacy paths field in the main example. The changes also correct an invalid pattern in the components example. The instructions are updated to explain the components field and how to use paths for backward compatibility. I've suggested re-including the paths field in the main JSON example to provide a more robust, backward-compatible default for users, as many will likely need to support older iOS versions.
| "components": [ | ||
| { | ||
| "/": "/*" | ||
| "/": "*" | ||
| } | ||
| ] |
There was a problem hiding this comment.
For better backward compatibility out of the box, I suggest re-adding the paths field to this example. While components is the modern approach, many developers still need to support older iOS versions. Providing an example that works for both modern and legacy versions by default is safer for users who might copy-paste the code without reading the instructions in detail. The accompanying text already does a great job explaining the purpose of each field, and this change would make the code example more robust.
| "components": [ | |
| { | |
| "/": "/*" | |
| "/": "*" | |
| } | |
| ] | |
| "paths": [ | |
| "*" | |
| ], | |
| "components": [ | |
| { | |
| "/": "*" | |
| } | |
| ] |
|
Visit the preview URL for this PR (updated for commit 74ec4c3): https://flutter-docs-prod--pr12978-fix-issue-12362-aasa-docs-5a7pw3zq.web.app |
|
@jmagman can someone on the iOS team take a look at this? |
3 participants
Fixes #12362. Updates 'Set up universal links' to use the modern 'components' field in AASA JSON and instructions, while retaining 'paths' for legacy support.