Skip to content

Conversation

@ericwindmill
Copy link
Contributor

On screens smaller than 500px wide, images were wider than the viewport.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@ericwindmill ericwindmill requested review from a team and sfshaza2 as code owners January 26, 2026 16:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ericwindmill, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a display issue where images in the /learn section of the site were appearing wider than the viewport on screens smaller than 500px. It introduces a dedicated CSS class to manage the responsiveness and maximum width of these images, ensuring a consistent and improved visual experience across various device sizes. The changes centralize image styling, moving away from inline declarations for better maintainability.

Highlights

  • Responsive Image Styling: Implemented max-width: 500px and width: 100% for images within .tutorial-page to ensure they scale correctly on smaller screens and do not exceed a maximum width.
  • New CSS Utility Class: Introduced a new CSS class, .learn-image-wrapper, to standardize the styling of images across the /learn section, centralizing display:flex, justify-self: center, max-width: 500px, and width: 100% properties.
  • Refactoring Inline Styles: Replaced redundant inline style attributes on image elements in src/content/learn/index.md, src/content/learn/pathway.md, and src/content/learn/tutorial/index.md with the new .learn-image-wrapper class for cleaner and more maintainable code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where images are wider than the viewport on small screens by moving inline styles to CSS classes. The changes are generally good, but I've found a few issues. There's some code duplication in the SCSS which can be refactored. The CSS properties used for centering images are unconventional and could be improved for better robustness. I also found a potential typo in a class name in one of the markdown files, and an incorrect attribute being used on a component which would prevent styles from being applied correctly. My detailed comments provide suggestions to address these points.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 26, 2026

Visit the preview URL for this PR (updated for commit b23aa02):

https://flutter-docs-prod--pr12994-fwe-image-fix-jm995uml.web.app

ericwindmill and others added 2 commits January 26, 2026 08:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 87c612f into main Jan 26, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the fwe-image-fix branch January 26, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants