Feat: (iOS and macOS) Add interface to get hasAdjustments property and base adjustment files #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-trieu-nguyen
requested review from
AlexV525 and
CaiJingLong
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apple has the hasAdjustments property to indicate whether the asset contains adjustment data.
Base adjustment files are unaltered versions of the asset before any edits were applied.
Partially solves
#1070
Now able to get the 'original version' of files. Getting AAE sidecar would be a similar implementation but have left out for now.
Motivation
immich-app/immich#4750
immich-app/immich#5818
Wanted ability to also upload the unedited image.
Things to note
PHAsset.hasAdjustments is only available on iOS and macOS 15.0+. Because this library targets 14.0, there is fallback implementation. The fallback implementation is very inefficient and could cause performance issues.
References
PHAssetResourceType
PHAsset.hasAdjustments