Skip to content

Conversation

zeqinjie
Copy link
Contributor

@zeqinjie zeqinjie commented Aug 3, 2025

I found that some of ( ValueNotifier & CurvedAnimation & TapGestureRecognizer) the memory leaks were not dispose

@AlexV525
Copy link
Member

AlexV525 commented Aug 3, 2025

From which indication that those fields need manual disposal?

@zeqinjie
Copy link
Contributor Author

zeqinjie commented Aug 3, 2025

From which indication that those fields need manual disposal?

Thank you for your review

  • We can refer to Flutter's official open issues link
  • Juejin articles link
image

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the process of refactoring the permission-limited overlay, which means the recognizer might be removed later. But let's just fix what we've discovered.

@zeqinjie zeqinjie requested a review from AlexV525 August 6, 2025 05:41
@AlexV525 AlexV525 merged commit 2ac2e30 into fluttercandies:main Aug 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants