Skip to content

Conversation

@MoRmdn
Copy link
Contributor

@MoRmdn MoRmdn commented Dec 15, 2024

  • Add devtools_options.yaml example configuration
  • Update iOS AppDelegate.swift
  • Fix RTL support in CupertinoControls
  • Fix RTL support in MaterialControls

- Add devtools_options.yaml example configuration
- Update iOS AppDelegate.swift
- Fix RTL support in CupertinoControls
- Fix RTL support in MaterialControls
Copy link
Collaborator

@maherjaafar maherjaafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori diegotori merged commit b2cea03 into fluttercommunity:master Jan 6, 2025
3 checks passed
diegotori added a commit that referenced this pull request Jan 6, 2025
@n0ks
Copy link

n0ks commented Jan 6, 2025

hey @maherjaafar @diegotori @MoRmdn , just a heads-up: the change to use withValues for color is a breaking change.

https://docs.flutter.dev/release/breaking-changes/wide-gamut-framework#opacity.

to fix this, the package constraints should be updated, and the version bumped. this change is breaking builds since it only works with flutter version 3.27.0 or later.

image

For now i've locked to the version to 1.8.5 to avoid having to deal with this problem

@diegotori
Copy link
Collaborator

diegotori commented Jan 6, 2025

@n0ks I just released version 1.9.0 which now requires Flutter 3.27.

prateekmedia pushed a commit to ente-io/chewie that referenced this pull request Feb 19, 2025
lg8294 added a commit to lg8294/chewie that referenced this pull request Aug 5, 2025
* commit '07b1e0acde9687047fe06ee95dd208524b2a862b':
  chewie, version 1.8.6. Addresses Issue fluttercommunity#874.
  Fixed dart lint issues.
  - Add devtools_options.yaml configuration files - Add devtools_options.yaml example configuration - Update iOS AppDelegate.swift - Fix RTL support in CupertinoControls - Fix RTL support in MaterialControls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants