Allow web favicon to be built from a different source image file #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good idea @galenwarren |
MarkOSullivan94
approved these changes
Sep 21, 2024
Collaborator
MarkOSullivan94
left a comment
MarkOSullivan94
left a comment
There was a problem hiding this comment.
LGTM thanks for your contribution @galenwarren
Collaborator
|
@galenwarren there's a conflict, can you address them and I'll get this merged? |
Author
|
@MarkOSullivan94 Thanks for taking a look at this! I hope this isn't a dumb question, but what conflict are you referring to? I'm happy to take a look but it's not jumping out at me. I do see that people have added commits to |
Author
|
@MarkOSullivan94 Just wanted to circle back on this. I'm happy to help but not quite sure what you're asking me to do. Would love to get this one merged, though, so I can retire my fork. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regards this issue.
It would be useful to be able to use a different source image to generate the favicon vs. the image icons for Flutter web. Two reasons:
Favicons with transparent backgrounds work well, in general, but transparent backgrounds don't work well for icons for PWA apps (a background gets assigned which might be white, might be black, etc.)
PWA icons have the same issue that Android icons do, i.e. adaptive icons need to limit content to the "safe zone" so that the icons can be cropped as needed. Favicons don't need this extra padding and really can't afford to have it, given how small they are to begin with.
This PR adds an
image_path_faviconoption to the config to allow one to override the source icon used to generate the web favicon. This would allow one to specify a non-padded icon with a transparent background to use for favicon generation and a padded icon with a solid-color background for other image generation.