feat(windows): multi-size .ico by default; deprecate windows.icon_size #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.icowith multiple embedded sizes: 16, 24, 32, 48, 256.windows.icon_size; log a non-fatal deprecation notice if present.Why
Behavior
icon_sizekept as deprecated).windows.icon_sizeexists, we log a deprecation notice (no failure).Tests
icon_size.package_version_test.dartto findpubspec.yamlrobustly across environments.dart analyzeanddart testpass locally.Migration
windows.icon_sizefrompubspec.yaml. No replacement needed.Implementation Notes
lib/windows/windows_icon_generator.dart: writes a multi-frame ICO (16, 24, 32, 48, 256) and logs deprecation.lib/config/windows_config.dart: keepsiconSizewith@Deprecatedfor parsing only (ignored by generator).Linked issues
Closes #573