feat(device_info_plus): Add User Device Name in Android (PR #3437)#3456
Merged
miquelbeltran merged 7 commits intofluttercommunity:mainfrom Feb 4, 2025
Merged
feat(device_info_plus): Add User Device Name in Android (PR #3437)#3456miquelbeltran merged 7 commits intofluttercommunity:mainfrom
miquelbeltran merged 7 commits intofluttercommunity:mainfrom
Conversation
NAME property now will send the customer user device name
miquelbeltran
approved these changes
Feb 4, 2025
Member
|
Thanks! |
ekuleshov
reviewed
Feb 7, 2025
|
|
||
| /// The name of the device. | ||
| /// https://developer.android.com/reference/android/provider/Settings.Global#DEVICE_NAME | ||
| final String name; |
Contributor
There was a problem hiding this comment.
this could use a note that name is only available on Android API level 25+
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the functionality of the NAME property to now include and send the customer's device name. This enhancement ensures that the application can capture and utilize the user device name for better identification, personalization, and debugging. Prior to this change, the NAME property did not include device-specific details. This update significantly improves logging, user tracking, and system behavior analysis.
Related Issues
In the current package, the user is unable to obtain the Android user's custom device name
e.g.
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).