Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an internal compiler error (ICE) that occurred when resolving associated refinements on dyn trait types. The issue arose because trait resolution for dyn Trait types falls into the builtin implementation path, but user-defined traits on dyn types don't have builtin refinement bodies, causing a panic when the code expected one.
Changes:
- Added a test case that reproduces the ICE scenario from issue #1519
- Added an early return in
normalize_alias_reftto handledyntrait types by treating them as unresolvable aliases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/tests/pos/surface/no_panic07.rs | Regression test demonstrating the fixed ICE when using associated refinements with dyn trait objects |
| crates/flux-infer/src/projections.rs | Added check to detect dyn trait types and return them as unresolved aliases instead of attempting builtin resolution |
Member
|
Superseded by #1522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1519.