fix: gateway router should wait for accepted condition#1791
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Oct 16, 2025
Merged
fix: gateway router should wait for accepted condition#1791stefanprodan merged 1 commit intofluxcd:mainfrom
stefanprodan merged 1 commit intofluxcd:mainfrom
Conversation
It can take some time for changes to propagate for cloud load balancers, so flagger should ensure the route changes are current before proceeding with any more. Signed-off-by: Steven Davidovitz <sdavidovitz@groq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
- Coverage 39.44% 30.43% -9.01%
==========================================
Files 287 287
Lines 22706 22074 -632
==========================================
- Hits 8956 6719 -2237
- Misses 12777 14626 +1849
+ Partials 973 729 -244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanprodan
approved these changes
Oct 16, 2025
Member
|
I think is Ok to check the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can take some time for changes to propagate for cloud load balancers, so flagger should ensure the route changes are current before proceeding with any more.
I'm not considering
observedGenerationoptional due to the upstream language, but I'm not sure if it's truly guaranteed so if it's easier to make this behavior opt-in then I'm happy to add it.https://github.com/kubernetes-sigs/gateway-api/blob/v1.2.1/site-src/guides/implementers.md?plain=1#L156C1-L160C23