fix: send succeeded webhooks with correct phase#1792
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Oct 16, 2025
Merged
fix: send succeeded webhooks with correct phase#1792stefanprodan merged 1 commit intofluxcd:mainfrom
stefanprodan merged 1 commit intofluxcd:mainfrom
Conversation
steved
force-pushed
the
steved/phase-succeeded-webhook
branch
from
1f6b143 to
60c6b70
Compare
Member
|
@steved can you please rebase and solve the conflicts. i would like to get this fixed merged before the next release. Thanks! |
Signed-off-by: Steven Davidovitz <sdavidovitz@groq.com>
steved
force-pushed
the
steved/phase-succeeded-webhook
branch
from
60c6b70 to
6fcbe19
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
- Coverage 39.44% 30.48% -8.97%
==========================================
Files 287 287
Lines 22706 22068 -638
==========================================
- Hits 8956 6727 -2229
- Misses 12777 14614 +1837
+ Partials 973 727 -246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When canary analysis has finished, webhooks are receiving payloads with either
Progressing(when analysis is skipped) orFinalising(when analysis is configured).