Rework selector labels #1830
Open
Rework selector labels #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinSnyderCodes
requested review from
aryan9600 and
stefanprodan
as code owners
KevinSnyderCodes
force-pushed
the
rework-selector-labels
branch
3 times, most recently
from
eb3b823 to
fc1ffcf
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
===========================================
- Coverage 39.44% 28.55% -10.89%
===========================================
Files 287 287
Lines 22706 22827 +121
===========================================
- Hits 8956 6518 -2438
- Misses 12777 15579 +2802
+ Partials 973 730 -243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KevinSnyderCodes
force-pushed
the
rework-selector-labels
branch
from
0fab806 to
223bcdb
Compare
Addresses fluxcd#1312, fluxcd#1257, fluxcd#1115 Retains all `matchLabels` in the primary `Deployment` or `DaemonSet`, instead of picking the first one that matches the `-selector-labels`. Recreates the primary `Deployment` or `DaemonSet` if the `matchLabels` of the existing object are not equal. This must be done since `matchLabels` is an immutable field. The recreate happens before promoting the canary to primary (i.e. no traffic is being routed to the primary). Still appends `-primary` to the value of the first label that matches `-selector-labels`. This ensures that the canary and primary have a unique set of selector labels. `Service` selector also uses the full set of `matchLabels` and overrides the value of the first matching `-selector-labels` to route to canary or primary. Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Tests the `matchLabels` behavior for `Deployment`, `DaemonSet`, and `Service` Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
Signed-off-by: Kevin Snyder <[email protected]>
KevinSnyderCodes
force-pushed
the
rework-selector-labels
branch
from
223bcdb to
24ffc5b
Compare
aryan9600
reviewed
Jan 2, 2026
Member
aryan9600
left a comment
aryan9600
left a comment
There was a problem hiding this comment.
thank you for working on this. i do agree that the current behaviour is limiting. but since this'd be a breaking change, i think we should gate this behaviour behind a flag (something like --copy-all-selector-labels which is set to false by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1312, #1257, #1115
Retains all
matchLabelsin the primaryDeploymentorDaemonSet, instead of picking the first one that matches the-selector-labels.Still appends
-primaryto the value of the first label that matches-selector-labels. This ensures that the canary and primary have a unique set of selector labels.Serviceselector also uses the full set ofmatchLabelsand overrides the value of the first matching-selector-labelsto route to canary or primary.Does not recreate the primary
DeploymentorDaemonSetif thematchLabelsof the existing object are not equal.Does update the
Serviceselector labels to match the new behavior.