Fix bug where CanaryWeight is reset to 0 during CanaryPhasePromoting#1851
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Mar 8, 2026
Merged
Conversation
sayap
force-pushed
the
fix-wrong-weight-when-promoting
branch
from
549d7c7 to
095a31d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 39.44% 30.00% -9.44%
==========================================
Files 287 287
Lines 22706 18467 -4239
==========================================
- Hits 8956 5541 -3415
+ Misses 12777 12195 -582
+ Partials 973 731 -242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aryan9600
approved these changes
Mar 7, 2026
Signed-off-by: Yap Sok Ann <sokann@gmail.com>
aryan9600
force-pushed
the
fix-wrong-weight-when-promoting
branch
from
095a31d to
ceab3ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a display issue in the status, that can cause some confusion.