Skip to content

Remove metrics metric after a canary is deleted #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlbertoSH wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove metrics metric after a canary is deleted #1856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbd46e9
Remove flagger_canary_status metric after a canary is deleted
AlbertoSH Nov 12, 2025
e52c17e
Deleting more metrics
AlbertoSH Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,11 @@ func (c *Controller) syncHandler(key string) error {
return nil
}

// Clean the metrics if marked for deletion
if cd.ObjectMeta.DeletionTimestamp != nil {
c.recorder.DeleteMetrics(cd)
}

// set status condition for new canaries
if cd.Status.Conditions == nil {
if err := c.setPhaseInitializing(cd); err != nil {
Expand Down
47 changes: 47 additions & 0 deletions pkg/metrics/recorder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,53 @@ func (cr *Recorder) IncFailures(labels CanaryMetricLabels) {
cr.failures.WithLabelValues(labels.Values()...).Inc()
}

// DeleteMetrics deletes the canary related metrics
func (cr *Recorder) DeleteMetrics(cd *flaggerv1.Canary) {
cr.DeleteDuration(cd)
cr.DeleteStatus(cd)
cr.DeleteWeight(cd)
for _, status := range []string{AnalysisStatusCompleted, AnalysisStatusSkipped} {
cr.DeleteSuccesses(CanaryMetricLabels{
Name: cd.Spec.TargetRef.Name,
Namespace: cd.Namespace,
DeploymentStrategy: cd.DeploymentStrategy(),
AnalysisStatus: status,
})
cr.DeleteFailures(CanaryMetricLabels{
Name: cd.Spec.TargetRef.Name,
Namespace: cd.Namespace,
DeploymentStrategy: cd.DeploymentStrategy(),
AnalysisStatus: status,
})
}
}

// DeleteDuration deletes the canary durations metric
func (cr *Recorder) DeleteDuration(cd *flaggerv1.Canary) {
cr.duration.DeleteLabelValues(cd.Spec.TargetRef.Name, cd.Namespace)
}

// DeleteStatus deletes the canary analysis status
func (cr *Recorder) DeleteStatus(cd *flaggerv1.Canary) {
cr.status.DeleteLabelValues(cd.Spec.TargetRef.Name, cd.Namespace)
}

// DeleteWeight sets the weight values for primary and canary destinations
func (cr *Recorder) DeleteWeight(cd *flaggerv1.Canary) {
cr.weight.DeleteLabelValues(fmt.Sprintf("%s-primary", cd.Spec.TargetRef.Name), cd.Namespace)
cr.weight.DeleteLabelValues(cd.Spec.TargetRef.Name, cd.Namespace)
}

// DeleteSuccesses deletes the total success metric
func (cr *Recorder) DeleteSuccesses(labels CanaryMetricLabels) {
cr.successes.DeleteLabelValues(labels.Values()...)
}

// DeleteFailures deletes the total failures metric
func (cr *Recorder) DeleteFailures(labels CanaryMetricLabels) {
cr.failures.DeleteLabelValues(labels.Values()...)
}

// GetStatusMetric returns the status metric
func (cr *Recorder) GetStatusMetric() *prometheus.GaugeVec {
return cr.status
Expand Down