Skip to content

List valid mesh providers in help and chart values #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtfurlan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

List valid mesh providers in help and chart values #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions artifacts/flagger/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,26 @@ spec:
provider:
description: Traffic managent provider
type: string
enum:
- apisix
- appmesh
- appmesh:v1beta2
- contour
- gatewayapi:v1
- gatewayapi:v1beta1
- gloo
- istio
- knative
- kubernetes
- kuma
- linkerd
- nginx
- osm
- skipper
- smi:v1alpha1
- smi:v1alpha2
- smi:v1alpha3
- traefik
metricsServer:
description: Prometheus URL
type: string
Expand Down
20 changes: 20 additions & 0 deletions charts/flagger/crds/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,26 @@ spec:
provider:
description: Traffic managent provider
type: string
enum:
- apisix
- appmesh
- appmesh:v1beta2
- contour
- gatewayapi:v1
- gatewayapi:v1beta1
- gloo
- istio
- knative
- kubernetes
- kuma
- linkerd
- nginx
- osm
- skipper
- smi:v1alpha1
- smi:v1alpha2
- smi:v1alpha3
- traefik
metricsServer:
description: Prometheus URL
type: string
Expand Down
2 changes: 1 addition & 1 deletion charts/flagger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ serviceMonitor:
# Set labels for the ServiceMonitor, use this to define your scrape label for Prometheus Operator
# labels:

# accepted values are kubernetes, istio, linkerd, appmesh, contour, nginx, gloo, skipper, traefik, apisix
# accepted values are apisix, appmesh, appmesh:v1beta2, contour, gatewayapi:v1, gatewayapi:v1beta1, gloo, istio, knative, kubernetes, kuma, linkerd, nginx, osm, skipper, smi:v1alpha1, smi:v1alpha2, smi:v1alpha3, traefik
meshProvider: ""

# single namespace restriction
Expand Down
2 changes: 1 addition & 1 deletion cmd/flagger/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func init() {
flag.BoolVar(&zapReplaceGlobals, "zap-replace-globals", false, "Whether to change the logging level of the global zap logger.")
flag.StringVar(&zapEncoding, "zap-encoding", "json", "Zap logger encoding.")
flag.StringVar(&namespace, "namespace", "", "Namespace that flagger would watch canary object.")
flag.StringVar(&meshProvider, "mesh-provider", "istio", "Service mesh provider, can be istio, linkerd, appmesh, contour, knative, gloo, nginx, skipper, traefik, apisix, osm or kuma.")
flag.StringVar(&meshProvider, "mesh-provider", "istio", "Service mesh provider, can be apisix, appmesh, appmesh:v1beta2, contour, gatewayapi:v1, gatewayapi:v1beta1, gloo, istio, knative, kubernetes, kuma, linkerd, nginx, osm, skipper, smi:v1alpha1, smi:v1alpha2, smi:v1alpha3, or traefik.")
flag.StringVar(&selectorLabels, "selector-labels", "app,name,app.kubernetes.io/name", "List of pod labels that Flagger uses to create pod selectors.")
flag.StringVar(&ingressAnnotationsPrefix, "ingress-annotations-prefix", "nginx.ingress.kubernetes.io", "Annotations prefix for NGINX ingresses.")
flag.StringVar(&ingressClass, "ingress-class", "", "Ingress class used for annotating HTTPProxy objects.")
Expand Down
20 changes: 20 additions & 0 deletions kustomize/base/flagger/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,26 @@ spec:
provider:
description: Traffic managent provider
type: string
enum:
- apisix
- appmesh
- appmesh:v1beta2
- contour
- gatewayapi:v1
- gatewayapi:v1beta1
- gloo
- istio
- knative
- kubernetes
- kuma
- linkerd
- nginx
- osm
- skipper
- smi:v1alpha1
- smi:v1alpha2
- smi:v1alpha3
- traefik
metricsServer:
description: Prometheus URL
type: string
Expand Down
Loading