Include HTTP status code in Prometheus error responses#1878
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Mar 2, 2026
Merged
Include HTTP status code in Prometheus error responses#1878aryan9600 merged 1 commit intofluxcd:mainfrom
aryan9600 merged 1 commit intofluxcd:mainfrom
Conversation
When Prometheus returns an HTTP error (4xx/5xx), the error message now includes the status code and reason phrase. Previously, only the response body was shown, which made it difficult to diagnose issues like HTTP 403 errors caused by missing authorization policies. Fixes fluxcd#1434 Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
aryan9600
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
- Coverage 39.44% 30.01% -9.43%
==========================================
Files 287 287
Lines 22706 18460 -4246
==========================================
- Hits 8956 5541 -3415
+ Misses 12777 12188 -589
+ Partials 973 731 -242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Prometheus returns an HTTP error (4xx/5xx), the error message previously only included the response body, producing messages like:
This made it difficult to diagnose issues such as HTTP 403 errors caused by missing authorization policies (e.g., Linkerd's
linkerdAuthPolicy.create=true).This change includes the HTTP status code and reason phrase in the error message, producing clearer output like:
Checklist