Skip to content

Add additionalVolumeMounts support for flagger chart#1880

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
nedal87:feat/helm-additional-volume-mounts
Mar 8, 2026
Merged

Add additionalVolumeMounts support for flagger chart#1880
aryan9600 merged 1 commit intofluxcd:mainfrom
nedal87:feat/helm-additional-volume-mounts

Conversation

@nedal87
Copy link
Contributor

@nedal87 nedal87 commented Feb 20, 2026

Summary

Add additionalVolumeMounts support to the Flagger Helm chart so users can mount custom files (for example CA bundles or config files) into the Flagger container directly through chart values.

This removes the need for post-render patches (such as Kustomize overlays) for a common customization pattern.

What Changed

  • Added additionalVolumeMounts: [] to charts/flagger/values.yaml
  • Normalized additionalVolumes default to [] in charts/flagger/values.yaml for type consistency with Kubernetes spec.volumes
  • Updated charts/flagger/templates/deployment.yaml:
    • volumes: is rendered when either controlplane.kubeconfig.secretName or additionalVolumes is set
    • volumeMounts: is rendered when either controlplane.kubeconfig.secretName or additionalVolumeMounts is set
    • Existing kubeconfig behavior remains unchanged
  • Documented additionalVolumes and additionalVolumeMounts in charts/flagger/README.md

Why

Users already have additionalVolumes, but there is no matching way to mount those volumes into the Flagger container from Helm values alone.

This change closes that gap and makes chart-based customization simpler and more complete while preserving backward compatibility. It also complements PR #1393, which originally added additionalVolumes.

Compatibility

  • No change to existing kubeconfig control plane behavior
  • Existing installs continue to render and deploy as before
  • additionalVolumes now uses a list default ([]), aligned with Kubernetes volumes schema

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.00%. Comparing base (12ee6cb) to head (4850415).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   39.44%   30.00%   -9.44%     
==========================================
  Files         287      287              
  Lines       22706    18467    -4239     
==========================================
- Hits         8956     5541    -3415     
+ Misses      12777    12195     -582     
+ Partials      973      731     -242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com>

use list default for additionalVolumes

Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com>

document additionalVolumes in chart readme

Signed-off-by: Nedal Eskaf <nedaleskaif87@gmail.com>
@aryan9600 aryan9600 force-pushed the feat/helm-additional-volume-mounts branch from c40b78a to 4850415 Compare March 8, 2026 03:08
@aryan9600 aryan9600 merged commit d716668 into fluxcd:main Mar 8, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants