Closed
Conversation
Signed-off-by: Georg Molau <georg.molau@gmail.com>
matheuscscp
reviewed
Apr 7, 2025
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
Thanks @gmolau! Can you please test the dashboards with this change and add some screenshots here? 🙏 Thanks!!!
Member
|
The revision label should be consistent across of Flux resources, in Flux the revision matches the source. I'm not for making this change as it would break everyone's alerts. You can make this change in your own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Revision" is the sequential number that Helm assigns to each release revision (i.e. to each update or rollback of a release). It is an incrementing counter set by Helm itself. chartVersion is the version of the chart semver or otherwise.
Previously the chartVersion was tracked in the "revision" label. This is now changed so that each label contains the right value.