Introduce support for looking up GH app installation ID #5682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
added
enhancement
matheuscscp
commented
Jan 19, 2026
Comment on lines
-73
to
-84
| if secretGitHubAppArgs.appID == "" { | ||
| return fmt.Errorf("--app-id is required") | ||
| } | ||
|
|
||
| if secretGitHubAppArgs.appInstallationID == "" { | ||
| return fmt.Errorf("--app-installation-id is required") | ||
| } | ||
|
|
||
| if secretGitHubAppArgs.privateKeyFile == "" { | ||
| return fmt.Errorf("--app-private-key is required") | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Make it like the flux-operator CLI: let the library validate.
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
gh-app-owner
branch
from
5005b43 to
d57313a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: fluxcd/pkg#1074, fluxcd/pkg#1076