Fix failure to read dangling symlink. #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
added
bug
matheuscscp
reviewed
Dec 21, 2025
This adds a dangling symlink to the testdata and code to skip reading the file if it's a symlink and can't be read. Signed-off-by: Kevin McDermott <bigkevmcd@gmail.com>
bigkevmcd
force-pushed
the
fix-symlink-reading-file
branch
from
bde3cdd to
990d9a3
Compare
stefanprodan
approved these changes
Dec 23, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
This was tested by @ennyjfrick and it works. Thanks @bigkevmcd 🏅
Member
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #995
This adds a dangling symlink to the testdata and code to skip reading the file if it's a symlink and can't be read.