Skip to content

Upgrade to Badger v4 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

Upgrade to Badger v4 #816

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d1819
Handle controller-runtime failing to add BadgerGC
stealthybox Sep 5, 2025
b162d0f
Upgrade badger to v4.8.0
stealthybox Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,11 @@ func main() {
}

if badgerGC != nil {
mgr.Add(badgerGC)
err := mgr.Add(badgerGC)
Copy link
Member

@matheuscscp matheuscscp Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I didn't know you could add runnable things to controller-runtime's Manager :o

Copy link
Member Author

@stealthybox stealthybox Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the first try at the GC was a mess of signal handlers and channels -- was delighted to find this 😮‍💨

if err != nil {
setupLog.Error(err, "unable to add GC to manager")
os.Exit(1)
}
}

probes.SetupChecks(mgr, setupLog)
Expand Down