Skip to content

Conversation

@gdasson
Copy link
Contributor

@gdasson gdasson commented Apr 23, 2024

With reference to this PR: fluxcd/pkg#723, I have referenced the kustomize constants from pkg now.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes to v1beta1 and v1beta2, these API versions are considered readonly.

@gdasson
Copy link
Contributor Author

gdasson commented Apr 23, 2024

sure

@gdasson
Copy link
Contributor Author

gdasson commented Apr 23, 2024

@stefanprodan : fixed as suggested.

@stefanprodan stefanprodan added the area/api API related issues and pull requests label Apr 23, 2024
@stefanprodan stefanprodan changed the title Refer condition type constants from pkg api: Refer condition type constants from fluxcd/pkg/apis Apr 23, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @gdasson 🏅

@stefanprodan stefanprodan merged commit 3e512c5 into fluxcd:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants