Add GroupChangeLog feature gate to fix es indexing cardinality#1361
Add GroupChangeLog feature gate to fix es indexing cardinality#1361stefanprodan merged 1 commit intofluxcd:mainfrom
GroupChangeLog feature gate to fix es indexing cardinality#1361Conversation
main.go
Outdated
| flag.BoolVar(&esLogging, "es-logging", false, | ||
| "Reduces cardinality in Elasticsearch by not using the kubernetes object as field name in logs") |
There was a problem hiding this comment.
Please remove this and add a feature flag called GroupedChangelog here: internal/features/features.go, also please use this name in all code instead of EsLogging.
There was a problem hiding this comment.
Updated and tested
{"level":"info","ts":"2025-02-13T12:07:31.518Z","logger":"setup","msg":"loading feature gate","GroupChangeLog":true}
internal/features/features.go
Outdated
| // opt-in from v1.3 | ||
| StrictPostBuildSubstitutions: false, | ||
| // GroupChangeLog | ||
| // opt-in from v2.5 |
There was a problem hiding this comment.
This refers to the kustomize-controller version, should be v1.5
There was a problem hiding this comment.
ah sorry, fixed
GroupChangeLog feature gate to fix es indexing cardinality
|
@94DanielBrown can you please squash all commits into one, then I can merge. Thanks! |
|
@94DanielBrown can you please signoff you commit |
|
@94DanielBrown see here how to signoff on the commit https://github.com/fluxcd/kustomize-controller/pull/1361/checks?check_run_id=37178702532 |
Signed-off-by: Daniel Brown <daniel.brown2@sainsburys.co.uk>
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @94DanielBrown 🏅
|
Final step is to document the feature gate here: https://github.com/fluxcd/website/blob/main/content/en/flux/components/kustomize/options.md#feature-gates |
GroupChangeLog feature gate to fix es indexing cardinalityGroupChangeLog feature gate to fix es indexing cardinality
Tested in kind
FYI I got error when using flux install to test
But installing with this worked fine as crd was v1 not v1beta2
k apply -f https://github.com/fluxcd/flux2/releases/latest/download/install.yamlexample logs from applying kustomization after