Skip to content

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 24, 2025

Revert controller-runtime from v0.20 to v0.19. The Kubernetes Aggregated Discovery was enabled in controller-runtime#2901 and looks like this feature is buggy resulting in old API versions being returned as the preferred version randomly.

This was observed on lots of cluster by Flux users, including on Kubernetes 1.32, 1.31 and OpenShift 4.16.

RC images:

  • ghcr.io/fluxcd/kustomize-controller:rc-deaabaa6
  • docker.io/fluxcd/kustomize-controller:rc-deaabaa6

@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label Feb 24, 2025
@stefanprodan
Copy link
Member Author

stefanprodan commented Feb 24, 2025

@matheuscscp can you please do this revert in helm-controller also, the restmapper is also used there.

@stefanprodan stefanprodan force-pushed the revert-controller-runtime-v0.19 branch from deaabaa to eaabaae Compare February 24, 2025 15:31
@erikgb
Copy link
Contributor

erikgb commented Feb 24, 2025

I have tested the RC image, and I still see some issues - but at a much lower scale. Example from an ephemeral cluster:

$ k logs -n flux-system kustomize-controller-548d7b9444-9ndxq | grep deprecated
{"level":"info","ts":"2025-02-24T15:10:29.814Z","logger":"KubeAPIWarningLogger","msg":"kyverno.io/v2beta1 ClusterCleanupPolicy is deprecated; use kyverno.io/v2 ClusterCleanupPolicy"}

@stefanprodan
Copy link
Member Author

stefanprodan commented Feb 24, 2025

@erikgb that warning should also be in all the other versions of Flux, we've reverted to what we've been using in 2.4

@erikgb
Copy link
Contributor

erikgb commented Feb 24, 2025

Yes, you are correct. But at a much lower scale. Here is an extract from our Splunk installation:
image

Almost all the log events are from after we upgraded to Flux 2.5.

@stefanprodan
Copy link
Member Author

Superseded by #1377

@stefanprodan stefanprodan deleted the revert-controller-runtime-v0.19 branch February 25, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants