Skip to content

Conversation

@matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented May 4, 2025

Depends on: fluxcd/pkg#919

Part of: fluxcd/flux2#5022

Closes: fluxcd/pkg#642

I tested this PR in the following setups:

OCIRepository

AWS:

  • Controller-level
  • Object-level

Azure:

  • Controller-level
  • Object-level

GCP:

  • Controller-level with GCP service account impersonation
  • Object-level with GCP service account impersonation
  • Object-level with direct access

OCI HelmRepository and HelmChart

The HelmRepository API does not have spec.serviceAccountName (neither spec.proxySecretRef btw). I'll leave it for the future (honestly I'd rather never add those two to force people to use OCIRepository for OCI helm charts instead).

AWS:

  • Controller-level

Azure:

  • Controller-level

GCP:

  • Controller-level

@matheuscscp matheuscscp force-pushed the rfc-0010-oci branch 3 times, most recently from 1f5fa0b to fa56e1f Compare May 5, 2025 19:09
@stefanprodan stefanprodan changed the title [RFC-0010] Introduce object-level workload identity for container registry APIs [RFC-0010] Introduce object-level workload identity for OCIRepository May 7, 2025
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

@stefanprodan stefanprodan added the area/oci OCI related issues and pull requests label May 7, 2025
@matheuscscp matheuscscp merged commit e253855 into main May 7, 2025
9 checks passed
@matheuscscp matheuscscp deleted the rfc-0010-oci branch May 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/oci OCI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache registry credentials for cloud providers

3 participants