fix: use no credentials file #1809
Conversation
TerryHowe
force-pushed
the
create-empty-credentials-file
branch
from
09435fc to
0384c65
Compare
|
I'm not sure this is the kind of fix we're looking for here... Does oras v2 still need this file to exist? If it does, we're just not gonna use oras anymore. In the other branch I was able to rip this file off. Following a test case in the debugger showed that oras was not writing any files but rather using a static credential in memory. Did you see the last 2 commits in that branch? |
|
It does not require the file to exist. |
Signed-off-by: Matheus Pimenta <[email protected]>
TerryHowe
force-pushed
the
create-empty-credentials-file
branch
from
0384c65 to
a86f542
Compare
|
Great! Then after we release Flux 2.6 this week we can upgrade to helm 3.18 and in this PR you can just cherry pick the last 2 commits I pushed to the other branch 👍 |
TerryHowe
changed the title
|
I just updated this PR with your one commit that should fix that problem |
|
|
||
| var errs []error | ||
| rClient, err := newClient(credentialsFile.Name(), tlsConfig, insecureHTTP) | ||
| rClient, err := newClient("", tlsConfig, insecureHTTP) |
There was a problem hiding this comment.
The controller is still in oras v1 so this won't work
Thanks but we didn't upgrade to oras v2 yet. Let's do it next week |
2 participants
Make the temporary credential file valid json