Skip to content

Conversation

@stefanprodan
Copy link
Member

Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan requested a review from matheuscscp May 27, 2025 06:17
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label May 27, 2025
@stefanprodan
Copy link
Member Author

@matheuscscp in TestOCIRepository_objectLevelWorkloadIdentityFeatureGate we call update in a loop then we update again the same object so the test will randomly fail due to the update race.

--- FAIL: TestOCIRepository_objectLevelWorkloadIdentityFeatureGate (0.89s)
    ocirepository_controller_test.go:3073: 
        Expected success, but got an error:
            <*errors.StatusError | 0xc00a25dae0>: 
            Operation cannot be fulfilled on ocirepositories.source.toolkit.fluxcd.io "ocirepository-reconcileddpm8": the object has been modified; please apply your changes to the latest version and try again

Signed-off-by: Matheus Pimenta <[email protected]>
@matheuscscp
Copy link
Member

@matheuscscp in TestOCIRepository_objectLevelWorkloadIdentityFeatureGate we call update in a loop then we update again the same object so the test will randomly fail due to the update race.

--- FAIL: TestOCIRepository_objectLevelWorkloadIdentityFeatureGate (0.89s)
    ocirepository_controller_test.go:3073: 
        Expected success, but got an error:
            <*errors.StatusError | 0xc00a25dae0>: 
            Operation cannot be fulfilled on ocirepositories.source.toolkit.fluxcd.io "ocirepository-reconcileddpm8": the object has been modified; please apply your changes to the latest version and try again

Yep I first noticed this in the helm 3.18 upgrade PR:

#1805 (comment)

https://github.com/fluxcd/source-controller/pull/1805/files#diff-4d0bfc777c67a80a5a394af0ffd62e1aec227c93bb10ed241a4ef4accaabedf2L3074

@matheuscscp matheuscscp merged commit fdc84c7 into main May 27, 2025
8 checks passed
@matheuscscp matheuscscp deleted the containerd-v1.7.27 branch May 27, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants