chore: Updated test coverage for RecordReconcileReq func #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
zhaque44
changed the title
|
Thanks @zhaque44, can you please squash this into a single commit? |
|
closing this PR: for this one: #1823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test scenarios:
Empty/whitespace annotation values Ensures that the func can handle edge cases where the annotation exists but has no meaningful content.
Overwrite existing status value Added a test to verify that reconcile annotation updates correctly overwrite any existing status value.
This will overall address edge cases and help with better test coverage