Skip to content

Fix: Prioritize sha2-512 and sha2-256 for ssh-rsa host keys #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix: Prioritize sha2-512 and sha2-256 for ssh-rsa host keys #1839

merged 1 commit into from
Jun 27, 2025

Conversation

@stefanprodan
Copy link
Member

Update github.com/fluxcd/pkg/git/gogit to v0.35.1 which includes: fluxcd/pkg#954

This PR fixes a regression bug introduce in fluxcd/pkg#943:

ssh: handshake failed: ssh: no common algorithm for host key;
client offered: [ssh-rsa], server offered: [rsa-sha2-512 rsa-sha2-256]

@stefanprodan stefanprodan requested a review from matheuscscp June 27, 2025 08:34
@stefanprodan stefanprodan added area/git Git related issues and pull requests dependencies Pull requests that update a dependency backport:release/v1.6.x To be backported to release/v1.6.x labels Jun 27, 2025
@stefanprodan stefanprodan mentioned this pull request Jun 27, 2025
Merged
@stefanprodan stefanprodan merged commit 4dec4c2 into main Jun 27, 2025
11 checks passed
@stefanprodan stefanprodan deleted the fix-ssh-host-key-sha2 branch June 27, 2025 08:44
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.6.x:

@fluxcdbot fluxcdbot mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matheuscscp matheuscscp matheuscscp approved these changes

Assignees

No one assigned

Labels

area/git Git related issues and pull requests backport:release/v1.6.x To be backported to release/v1.6.x dependencies Pull requests that update a dependency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stefanprodan @fluxcdbot @matheuscscp