Migrate Bucket controller to runtime/secrets #1852
Merged
+220
−773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cappyzawa
force-pushed
the
feat/bucket-controller-runtime-secrets-migration
branch
from
410ee9f to
ebf1405
Compare
21 tasks
cappyzawa
force-pushed
the
feat/bucket-controller-runtime-secrets-migration
branch
from
1de1e09 to
087d7e7
Compare
|
This PR applies the same TLS configuration updates that were implemented in #1855 and #1856. The Bucket controller now uses |
Replaces internal credential management with runtime/secrets package to standardize authentication, proxy configuration, and TLS handling across controllers. This migration eliminates code duplication by leveraging shared utilities and improves maintainability through consistent error handling patterns. The refactoring splits the large reconcileSource method into focused helper functions for better separation of concerns. Signed-off-by: cappyzawa <[email protected]>
Include namespace in secret error message for better debugging context. The secret name was already present in the error, but namespace information was missing, making it harder to identify which secret in which namespace was not found. Signed-off-by: cappyzawa <[email protected]>
Signed-off-by: cappyzawa <[email protected]>
cappyzawa
force-pushed
the
feat/bucket-controller-runtime-secrets-migration
branch
from
51cb0e0 to
9463bcf
Compare
stefanprodan
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fluxcd/flux2#5433