docs(framework): Fix typo in PyTorch tutorial#6669
Open
aramendi wants to merge 1 commit intoflwrlabs:mainfrom
Open
docs(framework): Fix typo in PyTorch tutorial#6669aramendi wants to merge 1 commit intoflwrlabs:mainfrom
aramendi wants to merge 1 commit intoflwrlabs:mainfrom
Conversation
Docs: Fix typo in PyTorch tutorial (franction -> fraction)
aramendi
requested review from
danieljanes,
panh99 and
tanertopal
as code owners
github-actions
bot
added
the
Contributor
Member
|
Thanks @aramendi ! I also note that a few lines above we also mention |
jafermarq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: Fix typo in PyTorch tutorial (franction -> fraction)
Issue
Description
In the code snippet explaining the strategy initialization, there is a misspelling in the configuration key:
... unchanged
fraction_train: float = context.run_config["franction-train"]
Initialize FedAdagrad strategy
Related issues/PRs
None
Proposal
Suggested fix:
Correct the typo in the configuration key to match the expected parameter name:
... unchanged
fraction_train: float = context.run_config["fraction-train"]
Initialize FedAdagrad strategy
Explanation
The key franction-train contains a typo and would cause a KeyError or unexpected behavior since the standard parameter name is fraction-train. This PR fixes the spelling in the tutorial documentation.