feat(hub): Init hub apps directory & dev tools#6762
Open
yan-gao-GY wants to merge 6 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Initializes hub/apps/ to track Flower Hub apps via symlinks to the examples/ repository and adds developer tooling to bump versions and publish apps to the Hub.
Changes:
- Added
hub/dev/publish_apps.shto publish one/all hub apps viaflwr app publish. - Added
hub/dev/bump_app_versions.pyto bumpproject.versionin apppyproject.tomlfiles. - Added many
hub/apps/*entries intended as symlinks to correspondingexamples/*apps.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| hub/dev/publish_apps.sh | Adds a CLI helper to publish selected/all Hub apps via flwr. |
| hub/dev/bump_app_versions.py | Adds a helper to bump project.version in app pyproject.toml files. |
| hub/apps/supernode-authentication | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-xgboost | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-tensorflow | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-sklearn | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-pytorch-lightning | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-pytorch | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-pennylane | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-pandas | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-numpy | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-monai | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-mlx | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-jax | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-huggingface | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-fastai | Adds a link to the corresponding examples/ app. |
| hub/apps/quickstart-catboost | Adds a link to the corresponding examples/ app. |
| hub/apps/opacus | Adds a link to the corresponding examples/ app. |
| hub/apps/flowertune-llm-medical | Adds a link to the corresponding examples/ app. |
| hub/apps/flowertune-llm-general-nlp | Adds a link to the corresponding examples/ app. |
| hub/apps/flowertune-llm-finance | Adds a link to the corresponding examples/ app. |
| hub/apps/flowertune-llm-code | Adds a link to the corresponding examples/ app. |
| hub/apps/flower-secure-aggregation | Adds a link to the corresponding examples/ app. |
| hub/apps/fl-tabular | Adds a link to the corresponding examples/ app. |
| hub/apps/fl-dp-sa | Adds a link to the corresponding examples/ app. |
| hub/apps/custom-mods | Adds a link to the corresponding examples/ app. |
Comments suppressed due to low confidence (1)
hub/apps/quickstart-xgboost:1
- These
hub/apps/*link targets are absolute paths on a specific machine. That will break for other developers/CI and also leaks local filesystem details into the repo. If these entries are meant to be symlinks, they should point to a repo-relative location (e.g.,../../examples/<app>from withinhub/apps/) so the links resolve anywhere the repo is checked out. (Same issue appears to apply to the other newly addedhub/apps/*entries in this PR.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…o add-hub-apps-dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
When apps in the
examplesrepository are updated (for example, during eachflwrrelease), the corresponding apps on the Flower Hub under theflwrlabsaccount must also be updated to stay in sync.Proposal
Create symlinks in
hub/apps/pointing to the examples that are already published on the Hub.Add helper scripts under
hub/dev/:bump_app_versions.py: Used to bump the app versions for Flower Hub apps.publish_apps.sh: Used to publish updated apps to the Hub.