Merge pull request #2 in CFA/coding-guidelines from NO_GOTO_NOR_EVAL to master

* commit 'd4f52cf72e64840f611a3db735d5a3d460fe2fa6':
  goto or eval is forbidden

Author: Maximilian Grosch

custom-standards/Flyeralarm/Sniffs/File/ForbiddenKeywordsSniff.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace flyeralarm\CodingGuidelines\Flyeralarm\Sniffs\File;
+
+use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Files\File;
+
+class ForbiddenKeywordsSniff implements Sniff
+{
+    /**
+     * @return array
+     */
+    public function register()
+    {
+        return array(T_CLASS, T_ABSTRACT, T_TRAIT);
+    }
+
+    /**
+     * @param File $phpcsFile
+     * @param int $stackPtr
+     * @return void
+     */
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        if ($phpcsFile->findNext(T_GOTO, 0)) {
+            $phpcsFile->addError(
+                'GOTO is not allowed',
+                $stackPtr,
+                'ForbiddenKeyword'
+            );
+        }
+
+        if ($phpcsFile->findNext(T_EVAL, 0)) {
+            $phpcsFile->addError(
+                'EVAL is not allowed',
+                $stackPtr,
+                'ForbiddenKeyword'
+            );
+        }
+    }
+}

ruleset.xml

@@ -7,6 +7,7 @@
     <rule ref="Generic.PHP.DisallowShortOpenTag"/>
     <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php"/>
+    <rule ref="./custom-standards/Flyeralarm/Sniffs/File/ForbiddenKeywordsSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/NoClassKindSuffixSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/Docblock/ReturnTypeSniff.php"/>
 </ruleset>

tests/rules/classes/not-allowed/ClassWithEval.php

@@ -0,0 +1,10 @@
+<?php
+// @expectedError EVAL is not allowed
+
+class ClassWithEval
+{
+    public function foo()
+    {
+        eval(1 + 1);
+    }
+}

tests/rules/classes/not-allowed/ClassWithGoto.php

@@ -0,0 +1,13 @@
+<?php
+// @expectedError GOTO is not allowed
+
+class ClassWithGoto
+{
+    public function foo()
+    {
+        goto foo;
+
+        foo:
+        return;
+    }
+}