Skip to content

Conversation

@osnyx
Copy link
Member

@osnyx osnyx commented Jan 30, 2026

pulls in flyingcircusio/nixpkgs#1119

PL-135139

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team
  • set urgency and risk labels
  • ensure the merge bot has determined a merge date
  • ensure all checks are green
  • get a review from a colleague

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • improve resilience of grub reading boot files from an XFS partition
  • Security requirements tested? (EVIDENCE)
    • in PL-135139, we were able to recover a stuck machine with these patches (25.11 branch)
    • smoke test: grub package builds with these patches
    • rebooting a machine has not been tried, we can be less strict about this development branch

Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could (and maybe should) wait for 26.05 to merge NixOS/nixpkgs#481112 ?

@ctheune ctheune merged commit f6c2cf2 into fc-26.05-dev Feb 2, 2026
4 of 5 checks passed
@ctheune ctheune deleted the PL-135139-26.05-nixpkgs branch February 2, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants