Skip to content

feat: Deployment ID + replay wrapper + anchors; docs+tests#92

Open
flyingrobots wants to merge 12 commits intomainfrom
pr/feat-replay-deploy-anchors
Open

feat: Deployment ID + replay wrapper + anchors; docs+tests#92
flyingrobots wants to merge 12 commits intomainfrom
pr/feat-replay-deploy-anchors

Conversation

@flyingrobots
Copy link
Owner

Adds --deployment/SHIPLOG_DEPLOY_ID with trailer deployment.id (mirrored to why.ticket when unset), git shiplog replay wrapper + script with --since-anchor/--pointer/--tag, and anchor set|show|list. Includes docs and tests.

feat(run): fun confirmation glyphs (🚢🪵 + ⚓️ when anchor, else ✅); honor SHIPLOG_CONFIRM_TEXT override
refactor(run): simplify dry-run branch to single cmd_write call; dry-run still prints 'Would execute' and 'Would sign & append' previews
…end 🚢🪵✅/🚢🪵❌; prefix console lines with ' | ' while keeping raw logs
- Add preamble and confirmation controls to env reference
- Update run/write/command-reference with preamble, glyph defaults, quiet mode
- Note default --no-verify pushes in write/publish docs
- Link env reference from docs index
…s, auto-push notes) and link to env reference
…pports range/count, speed multiplier, step mode, and notes display
…h flag

feat(verify/sign): surface concise reasons from git verify-commit and ssh-keygen; warn on suspicious command substitution tokens; alias --attach for --log
chore(dev): add scripts/install-dev.sh symlink helper
…and --attach alias on write; warn on literal command-substitution tokens
- run: add --deployment flag/env; include deployment.id in trailer; mirror to ticket when missing
- write: add --deployment flag/env; overlay deployment.id in trailer; ticket fallback
- append: add --deployment flag/env; overlay deployment.id; ticket fallback
…lter

- Docs: env (SHIPLOG_DEPLOY_ID), run/write/append flags, command-reference, replay usage
- Replay: add --deployment / --ticket filter backed by export-json
- Tests: stamp deployment.id, mirror ticket, and replay filter
- Helper: scripts/shiplog-deploy-id.sh to mint IDs
… docs index and README Deployments & Replay section
- Add command pages: replay wrapper, anchor, deploy-id
- Update README and docs index with links
- Update feature docs: run/write/append/export-json/replay with deployment and anchor details
- Update JSON schema doc to include optional 'deployment' object
…-pointer/--tag) and git shiplog anchor set|show|list; tests; README link updates
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c3bab18 and 6f6ed43.

⛔ Files ignored due to path filters (1)
  • README.md is excluded by !*.md
📒 Files selected for processing (27)
  • docs/README.md (1 hunks)
  • docs/commands/anchor.md (1 hunks)
  • docs/commands/deploy-id.md (1 hunks)
  • docs/commands/replay.md (1 hunks)
  • docs/features/append.md (1 hunks)
  • docs/features/command-reference.md (2 hunks)
  • docs/features/export-json.md (1 hunks)
  • docs/features/replay.md (1 hunks)
  • docs/features/run.md (3 hunks)
  • docs/features/write.md (2 hunks)
  • docs/reference/env.md (2 hunks)
  • docs/reference/json-schema.md (2 hunks)
  • lib/commands.sh (43 hunks)
  • lib/common.sh (3 hunks)
  • lib/git.sh (2 hunks)
  • scripts/install-dev.sh (1 hunks)
  • scripts/shiplog-deploy-id.sh (1 hunks)
  • scripts/shiplog-replay.sh (1 hunks)
  • scripts/shiplog-trust-sign.sh (1 hunks)
  • scripts/shiplog-verify-trust.sh (2 hunks)
  • test/27_verify_shows_reason.bats (1 hunks)
  • test/28_trust_sign_sshkeygen_error.bats (1 hunks)
  • test/29_run_preamble_and_warnings.bats (1 hunks)
  • test/30_write_attach_flag.bats (1 hunks)
  • test/31_deploy_id_and_replay.bats (1 hunks)
  • test/32_replay_wrapper.bats (1 hunks)
  • test/33_anchor_commands.bats (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pr/feat-replay-deploy-anchors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1183 to +1188
tip_sha="$(git rev-parse "$journal_ref" 2>/dev/null || true)"
if git rev-parse --verify "$anchor_ref" >/dev/null 2>&1; then
anchor_sha="$(git rev-parse "$anchor_ref")"
from="$anchor_sha"
[ -z "$to" ] && to="$tip_sha"
else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge --since-anchor replay returns no entries

cmd_replay defaults to to the journal tip whenever --since-anchor is used (to="$tip_sha"). The wrapper later forwards this value as --to <tip> to scripts/shiplog-replay.sh, which constructs git rev-list <tip>..<ref>; when both arguments point at the same tip commit the rev-list is empty, so git shiplog replay --since-anchor always prints nothing even when entries exist after the anchor. Dropping the implicit --to (or using the anchor as the left side of the range) would allow the anchor replay to function.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments