Skip to content

fix: accept 204 No Content status code in ping method #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahoo12138 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: accept 204 No Content status code in ping method #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b43ba2
fix: accept 204 No Content status code in ping method
Mahoo12138 Jun 7, 2025
830c185
refactor: improve OPTIONS request validation
Mahoo12138 Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ class Client {
this.c.options.receiveTimeout = Duration(milliseconds: timeout);

/// Test whether the service can connect
/// Accepts both 200 OK and 204 No Content status codes as valid responses
Future<void> ping([CancelToken? cancelToken]) async {
var resp = await c.wdOptions(this, '/', cancelToken: cancelToken);
if (resp.statusCode != 200) {
if (resp.statusCode != 200 && resp.statusCode != 204) {
throw newResponseError(resp);
}
}
Expand Down
23 changes: 10 additions & 13 deletions lib/src/webdav_dio.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ class WdDio with DioMixin implements Dio {
optionsHandler: (options) => options.headers?['depth'] = '0',
cancelToken: cancelToken);
}

// OPTIONS validate
void _validateOptionsResponse(Response response) {
if (response.statusCode == 200 || response.statusCode == 204) {
throw newResponseError(response);
}
}
// // quota
// Future<Response> wdQuota(Client self, String dataStr,
// {CancelToken cancelToken}) {
Expand Down Expand Up @@ -249,9 +254,7 @@ class WdDio with DioMixin implements Dio {
}) async {
// fix auth error
var pResp = await this.wdOptions(self, path, cancelToken: cancelToken);
if (pResp.statusCode != 200) {
throw newResponseError(pResp);
}
this._validateOptionsResponse(pResp);

var resp = await this.req(
self,
Expand Down Expand Up @@ -291,9 +294,7 @@ class WdDio with DioMixin implements Dio {
}) async {
// fix auth error
var pResp = await this.wdOptions(self, path, cancelToken: cancelToken);
if (pResp.statusCode != 200) {
throw newResponseError(pResp);
}
this._validateOptionsResponse(pResp);

Response<ResponseBody> resp;

Expand Down Expand Up @@ -457,9 +458,7 @@ class WdDio with DioMixin implements Dio {
}) async {
// fix auth error
var pResp = await this.wdOptions(self, path, cancelToken: cancelToken);
if (pResp.statusCode != 200) {
throw newResponseError(pResp);
}
this._validateOptionsResponse(pResp);

// mkdir
await this._createParent(self, path, cancelToken: cancelToken);
Expand Down Expand Up @@ -492,9 +491,7 @@ class WdDio with DioMixin implements Dio {
}) async {
// fix auth error
var pResp = await this.wdOptions(self, path, cancelToken: cancelToken);
if (pResp.statusCode != 200) {
throw newResponseError(pResp);
}
this._validateOptionsResponse(pResp);

// mkdir
await this._createParent(self, path, cancelToken: cancelToken);
Expand Down