Skip to content

Conversation

@debasisdwivedy
Copy link
Contributor

Converting the code below:

if auth_type is None:
        return "pkce"
if auth_type.lower() in _pkce_options:
        return "Pkce"

to

if auth_type is None or auth_type.lower() in _pkce_options:
        return "Pkce"

import rich.box
import rich.repr
import rich_click as click
import click.exceptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wy?

import rich.box
import rich.repr
import rich_click as click
import click.exceptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this changes the import back to click we want to continue using rich_click

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted it back. But i think would be better as it would only import the exceptions from the click package. rich-click does not have exception module exposed, it internally calls click.exception. It does not show during static code analysis and might create problems at runtime.

This would even better as we are explicitly calling the exception package:

from click.exceptions import Exit, NoArgsIsHelpError

We can add it later if we find any issue

Signed-off-by: debasisdwivedy <[email protected]>
Signed-off-by: debasisdwivedy <[email protected]>
This reverts commit 83d47a2.

Signed-off-by: debasisdwivedy <[email protected]>
This reverts commit b65b940.

Signed-off-by: debasisdwivedy <[email protected]>
Signed-off-by: debasisdwivedy <[email protected]>
@debasisdwivedy debasisdwivedy force-pushed the sanitize_auth_type_pkce branch from 9c15a44 to ca1821a Compare January 7, 2026 03:54
@kumare3 kumare3 merged commit e6c5a8c into flyteorg:main Jan 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants