-
Notifications
You must be signed in to change notification settings - Fork 22
combining pkce enum types #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/flyte/cli/_common.py
Outdated
| import rich.box | ||
| import rich.repr | ||
| import rich_click as click | ||
| import click.exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wy?
src/flyte/cli/_common.py
Outdated
| import rich.box | ||
| import rich.repr | ||
| import rich_click as click | ||
| import click.exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this changes the import back to click we want to continue using rich_click
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted it back. But i think would be better as it would only import the exceptions from the click package. rich-click does not have exception module exposed, it internally calls click.exception. It does not show during static code analysis and might create problems at runtime.
This would even better as we are explicitly calling the exception package:
from click.exceptions import Exit, NoArgsIsHelpError
We can add it later if we find any issue
Signed-off-by: debasisdwivedy <[email protected]>
Signed-off-by: debasisdwivedy <[email protected]>
This reverts commit 83d47a2. Signed-off-by: debasisdwivedy <[email protected]>
This reverts commit b65b940. Signed-off-by: debasisdwivedy <[email protected]>
Signed-off-by: debasisdwivedy <[email protected]>
9c15a44 to
ca1821a
Compare
Converting the code below:
to