Improve error message when no files found to bundle #582
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a more descriptive error message that includes: - The directory being searched - Possible causes (venv, .gitignore, no Python files) - Debugging guidance Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
reviewed
Jan 27, 2026
src/flyte/_code_bundle/bundle.py
Outdated
| logger.debug(f"Finding files to bundle, ignoring as configured by: {ignore}") | ||
| files, digest = list_files_to_bundle(from_dir, True, *ignore, copy_style=copy_style) | ||
| if len(files) == 0: | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
can we make this a flyte.errors.CodeBundleError
Replace ValueError with a custom CodeBundleError exception for better error handling when no files are found to bundle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
reviewed
Jan 27, 2026
| except Exception as e: | ||
| console.print(common.get_panel("Exception", f"[red]✕ Execution failed:[/red] {e}", config.output_format)) | ||
| raise | ||
| exit(1) |
kumare3
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build_code_bundlefinds no files to bundle