Conversation
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
|
Seems like there's no "logs" tab when using |
| if not admin and not task: | ||
| raise click.BadParameter("At least one of --endpoint or --org must be provided.") |
There was a problem hiding this comment.
I think we do not need this check if we only set local? As those are for remote
There was a problem hiding this comment.
that is interesting, lets do this as a follow up
src/flyte/_persistence/_run_store.py
Outdated
| @staticmethod | ||
| def list_runs_sync() -> list[RunRecord]: | ||
| """List top-level runs (action_name='a0') ordered by start_time DESC.""" | ||
| with LocalDB._write_lock: |
There was a problem hiding this comment.
list_runs_sync, list_actions_for_run_sync, and get_action_sync are using SELECT only, I think they do not need write_lock?
There was a problem hiding this comment.
great call out (vibing)
| db_path = LocalDB._get_db_path() | ||
| conn = await aiosqlite.connect(db_path) | ||
| await conn.execute(_TASK_CACHE_DDL) | ||
| await conn.execute(_RUNS_DDL) |
There was a problem hiding this comment.
nit: maybe we can add index after this to optimize queries (also in initialize_sync)
There was a problem hiding this comment.
which index do we need, i dont see any queries that need an index right now right?
There was a problem hiding this comment.
we can add them as we need them?
There was a problem hiding this comment.
i found one place, for list runs and sorting it by time would help. So i am adding it now
Yes, we dont store the logs, so you cannot see the logs for older stuff |
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
wild-endeavor
left a comment
wild-endeavor
left a comment
There was a problem hiding this comment.
is this backwards compatible or will we need to clear the local db?
3 participants
First
Then, this or flyte.run will be recorded. you can also set in
flyte.init(local_persistence=True)And now you can checkout and browse all old runs
Screen.Recording.2026-02-06.at.4.46.00.PM.mov