feat: add support for AWS_CONFIG_FILE env vars#750
Merged
kumare3 merged 4 commits intoflyteorg:mainfrom Mar 6, 2026
Merged
Conversation
ljstrnadiii
force-pushed
the
s3_config_file
branch
from
649b491 to
3a39cfb
Compare
ljstrnadiii
changed the title
AWS_CONFIG_FILE env vars
pingsutw
previously approved these changes
Mar 5, 2026
Signed-off-by: ljstrnadiii <ljstrnadiii@gmail.com>
Signed-off-by: ljstrnadiii <ljstrnadiii@gmail.com>
Signed-off-by: ljstrnadiii <ljstrnadiii@gmail.com>
ljstrnadiii
force-pushed
the
s3_config_file
branch
from
3a39cfb to
7b1f45f
Compare
Contributor
Author
|
@pingsutw any way we can get this into the next release? If so, any idea when that might be? |
kumare3
reviewed
Mar 6, 2026
| aws_config_file: str, | ||
| region: str | None, | ||
| ) -> typing.Any: | ||
| import boto3 |
Contributor
There was a problem hiding this comment.
:(, dont want botocore at all, but i guess this is completely user specific, can you please document it in the docs
kumare3
previously approved these changes
Mar 6, 2026
Signed-off-by: ljstrnadiii <ljstrnadiii@gmail.com>
kumare3
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.