Add NodeMetadata.Config property bag and expose ClusterAssignment in LaunchPlan#6173
Closed
Add NodeMetadata.Config property bag and expose ClusterAssignment in LaunchPlan#6173
Conversation
…LaunchPlan Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Collaborator
Code Review Agent Run Status
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6173 +/- ##
==========================================
- Coverage 37.05% 33.25% -3.81%
==========================================
Files 1318 1020 -298
Lines 132627 108679 -23948
==========================================
- Hits 49151 36138 -13013
+ Misses 79226 69344 -9882
+ Partials 4250 3197 -1053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This allows plugins to pass execution instructions to the backend plugin without having to introduce new protos..
What changes were proposed in this pull request?
Allow passing cluster_assignment in Workflow NodeMetadata and LaunchPlan.
How was this patch tested?
Deployed to an internal tenant and verified the bits are passed correctly.
Setup process
Screenshots
Check all the applicable boxes
Summary by Bito
This PR introduces a new config property bag in NodeMetadata enabling plugins to pass execution instructions without new proto definitions, and adds support for cluster_assignment in LaunchPlan specifications. The changes span across multiple language implementations including Go, TypeScript, Python, and Rust, enhancing the flexibility of plugin configuration and execution control.Unit tests added: False
Estimated effort to review (1-5, lower is better): 5