Skip to content

update update_all_versions command #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 22 commits into from
Apr 10, 2025
Merged

update update_all_versions command #3219

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7ce9b62
update update_all_versions command
pingsutw Apr 9, 2025
52ff3f6
test ci
pingsutw Apr 9, 2025
8042211
test
pingsutw Apr 9, 2025
a78645f
test
pingsutw Apr 9, 2025
793d3ad
test
pingsutw Apr 9, 2025
51158b1
test
pingsutw Apr 9, 2025
25db60e
test
pingsutw Apr 9, 2025
0cdeb64
test
pingsutw Apr 9, 2025
f14eb75
test
pingsutw Apr 9, 2025
297fbd6
test
pingsutw Apr 9, 2025
6e1779c
test
pingsutw Apr 9, 2025
95884e3
test
pingsutw Apr 9, 2025
4e59954
test
pingsutw Apr 9, 2025
033449f
test
pingsutw Apr 9, 2025
27465ba
test
pingsutw Apr 9, 2025
7f995b5
test ci
pingsutw Apr 9, 2025
fe5f551
test
pingsutw Apr 9, 2025
b4fa544
Revert "test"
pingsutw Apr 9, 2025
3c843cb
test
pingsutw Apr 9, 2025
553abf7
update
pingsutw Apr 9, 2025
4562e3a
nit
pingsutw Apr 9, 2025
24dd082
lint
pingsutw Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ update_all_versions:
# ensure the placeholder is there. If grep doesn't find the placeholder
# it exits with exit code 1 and github actions aborts the build.
./run_all_plugins.sh grep "$(PLACEHOLDER)" "$(VERSION_FILE)"
./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)
./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)\/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)
Copy link
Contributor

@flyte-bot flyte-bot Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect escape sequence in sed pattern

The sed command has an incorrect escape sequence. The backslash before the forward slash creates an incorrect pattern that won't match the placeholder correctly. Remove the backslash before the forward slash.

Code suggestion
Check the AI-generated fix before applying
Suggested change
./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)\/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)
./run_all_plugins.sh sed -i "s/$(PLACEHOLDER)/__version__ = \"${VERSION}\"/g" $(VERSION_FILE)

Code Review Run #dd580d

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

Loading